fix: fixes an ACP interoperability issue when OpenCode is used with the Agent Client Protocol Python SDK over stdio #17017
Open
zztdandan wants to merge 2 commits intoanomalyco:devfrom
Open
fix: fixes an ACP interoperability issue when OpenCode is used with the Agent Client Protocol Python SDK over stdio #17017zztdandan wants to merge 2 commits intoanomalyco:devfrom
stdio #17017zztdandan wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #17019
Type of change
What does this PR do?
This PR fixes an ACP interoperability issue when OpenCode is used with the Agent Client Protocol Python SDK over
stdio.In this integration mode, JSON-RPC payload size is effectively constrained (observed around the 64KB boundary in practice for this path). When a single emitted JSON message exceeds this boundary, the Python SDK side can hit a fatal error on the stdio channel/port handling path, which can break ACP communication for the client session.
OpenCode tool updates can easily exceed that limit:
rawOutput.outputis often very large.tool_call_update.content[].content.textcan also become large (for example,readon moderately large files).To prevent oversized ACP messages from causing fatal stdio-side failures and breaking delivery, this change applies field-level truncation for those two high-risk text fields before sending
tool_call_updatepayloads to ACP.What changed:
tool_call_updatepayloads.Why this works:
Scope of truncation (only):
update.content[].content.textupdate.rawOutput.outputNo other ACP update types are altered.
Notes:
How did you verify your code works?
I validated this change with:
After this change, the ACP Python SDK can reliably receive previously oversized tool-update messages in truncated form.
Screenshots / recordings
N/A (non-UI change).
Checklist