fix(tui): improve session scrollbar contrast#17446
Open
jiangyinzuo wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): improve session scrollbar contrast#17446jiangyinzuo wants to merge 1 commit intoanomalyco:devfrom
jiangyinzuo wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Hello @adamdotdevin , can you please review the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17448
Type of change
What does this PR do?
Fixes the main session scrollbar thumb color in the TUI. The session pane was using
theme.border, which is too close to the track color in the solarized theme. This changes it totheme.borderActive, matching the sidebar and permission panels and making the scrollbar visible again.How did you verify your code works?
Ran
bun typecheckinpackages/opencodeafter the change and checked the theme code path to confirm the main session scrollbar now uses the active border color.Screenshots / recordings
before
after
Checklist