Skip to content

fix(app): agent switch should not reset thinking level #17470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nexxeln merged 2 commits into from
Mar 16, 2026
+25 −2
Merged

fix(app): agent switch should not reset thinking level #17470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1701d00
fix(app): agent switch should not reset thinking level
bugulo Mar 14, 2026
0dccac5
test(app): add e2e test for variant preservation across agent switches
bugulo Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/app/e2e/session/session-model-persistence.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,3 +349,25 @@ test("session model restore across workspaces", async ({ page, withProject }) =>
await waitFooter(page, firstState)
})
})

test("variant preserved when switching agent modes", async ({ page, withProject }) => {
await page.setViewportSize({ width: 1440, height: 900 })

await withProject(async ({ directory, gotoSession }) => {
await gotoSession()

await ensureVariant(page, directory)
const updated = await chooseDifferentVariant(page)

const available = await agents(page)
const other = available.find((name) => name !== updated.agent)
test.skip(!other, "only one agent available")
if (!other) return

await choose(page, promptAgentSelector, other)
await waitFooter(page, { agent: other, variant: updated.variant })

await choose(page, promptAgentSelector, updated.agent)
await waitFooter(page, { agent: updated.agent, variant: updated.variant })
})
})
5 changes: 3 additions & 2 deletions packages/app/src/context/local.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,11 @@ export const { use: useLocal, provider: LocalProvider } = createSimpleContext({
model: item.model,
variant: item.variant ?? null,
})
const prev = scope()
const next = {
agent: item.name,
model: item.model,
variant: item.variant,
model: item.model ?? prev?.model,
variant: item.variant ?? prev?.variant,
} satisfies State
const session = id()
if (session) {
Expand Down
Loading