Skip to content

fix(session): prevent assistant-last message array from reaching provider APIs #18421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brendandebeasi wants to merge 1 commit into from
Closed

fix(session): prevent assistant-last message array from reaching provider APIs #18421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions packages/opencode/src/session/message-v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,13 +782,19 @@ export namespace MessageV2 {

const tools = Object.fromEntries(Array.from(toolNames).map((toolName) => [toolName, { toModelOutput }]))

return convertToModelMessages(
result.filter((msg) => msg.parts.some((part) => part.type !== "step-start")),
{
//@ts-expect-error (convertToModelMessages expects a ToolSet but only actually needs tools[name]?.toModelOutput)
tools,
},
)
const filtered = result.filter((msg) => msg.parts.some((part) => part.type !== "step-start"))
if (filtered.length > 0 && filtered[filtered.length - 1].role === "assistant") {
filtered.push({
id: MessageID.ascending(),
role: "user",
parts: [{ type: "text", text: "Continue." }],
})
}

return convertToModelMessages(filtered, {
//@ts-expect-error (convertToModelMessages expects a ToolSet but only actually needs tools[name]?.toModelOutput)
tools,
})
}

export const page = fn(
Expand Down
Loading