Merged
Conversation
…t before this PR can be merged VERYYYY IMPORTANTgcleangclean
…efore we can fix the remaining ones
…is LanguageModelV3 instead of LanuageModel union (should fix compat in llm.ts)
…things that need migration for copilot sdk
…t and tool-approval-response, fix type inference w/ union stuff
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
kitlangton
reviewed
Mar 27, 2026
Contributor
|
/review and don't you dare just say LGTM |
Contributor
|
lgtm |
Collaborator
Author
|
I don't think that the header thing should be an issue for many if any providers, should it become one we will explore approaches to fix it depending on use case. As a work around if someone were to encounter an issue they could always temporarily create a provider hook that overrides the fetch impl and drops the headers. See codex.ts for example of how to override fetch. (U could also downgrade ofc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
do we need to disable this logger? https://ai-sdk.dev/docs/migration-guides/migration-guide-6-0#warning-logger(it's already disabled)fix model convertions in message-v2finish migrating the copilot sdkget gitlab ai sdk migrated to v6Figure out what we should do since "unknown" -> "other" (see here: feat: expose raw finish reason vercel/ai#11338 forget why we had the "unknown" case in the first place)<< This should be addressed but we may encounter some providers that we need to handle the RAW finish reason more preciselytry to find work around for temp top_p for minimax like providers