fix(provider): handle delayed tool call names in streamed responses#18623
Open
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Open
fix(provider): handle delayed tool call names in streamed responses#18623Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #16488
Type of change
What does this PR do?
This fixes a streamed tool-call parsing issue in the OpenAI-compatible chat model path.
Some OpenAI-compatible providers can stream
tool_callswhere the first delta includes the call id and partial arguments, butfunction.namearrives in a later chunk. The current parser treated a missingfunction.namein the first chunk as a fatal error and aborted the loop.This change makes the parser buffer incomplete tool call deltas until the tool name is available. Once the name arrives, it emits the normal tool input events and continues with the existing completion flow. I also kept the flush behavior aligned with the previous implementation so normal providers should not change behavior.
I added:
function.namestreaming caseHow did you verify your code works?
I tested the changes locally with:
bun test test/provider/copilot/copilot-chat-model.test.tsbun test test/session/message-v2.test.tsbun typecheckI also pushed with the repo's pre-push checks enabled, and
bun turbo typecheckcompleted successfully.Screenshots / recordings
N/A — no UI change.
Checklist