feat(ui): make edited file references clickable in desktop session UI#19153
Open
anduimagui wants to merge 12 commits intoanomalyco:devfrom
Open
feat(ui): make edited file references clickable in desktop session UI#19153anduimagui wants to merge 12 commits intoanomalyco:devfrom
anduimagui wants to merge 12 commits intoanomalyco:devfrom
Conversation
Move inline file-path parsing into a shared helper and add focused tests, including Windows file URL handling, so clickable markdown file links stay stable as parsing rules evolve.
Render clickable tool filenames as native buttons with focus-visible styles so edit/write/apply_patch file links are accessible and keep existing click-to-open behavior.
Route markdown and tool file-link clicks to the desktop openPath integration when available, with in-app review fallback if external open fails. Also harden file-ref parsing for wrapped paths and ensure in-app fallback activates the opened tab.
When external open is unavailable or fails, opening from clickable file refs now preserves optional line numbers by selecting the target line in the review file tab.
Open filenames in review and use the adjacent icon for external app launches — with clearer labels for both actions.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on the search results, here are the related PRs: Related PR #15269 - "feat(ui): make edited file references clickable in desktop session UI"
Related PR #18836 - "feat: add clickable markdown file references"
Related PR #11429 - "feat: add clickable file paths in agent responses (web UI only)"
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #13430
Type of change
What does this PR do?
This is a clean replacement for #15269, rebuilt on top of current
devso the diff stays focused on clickable file references in the desktop session UI.It makes file references in session output clickable so users can open files directly from agent responses and tool results.
The change adds shared
openFilePathplumbing, detects file-like inline code references (includingpath:lineandfile://...) in markdown, and wires clicks inedit/write/apply_patchfile labels to open the file in the review panel.Related work and how this is different (plain English)
How this PR differs:
src/foo.ts,src/foo.ts:42, andfile://...) and also makes filenames insideedit/write/apply_patchcards clickable.openFilePathplumbing.How did you verify your code works?
packages/uiandpackages/appchanges.bun typecheckinpackages/uicurrently fails locally because@tsconfig/node22/tsconfig.jsonis missing in this environment.bun typecheckinpackages/appcurrently fails locally because workspace dependencies/types are unavailable in this environment.Screenshots / recordings
Notes
devhistory noise.Checklist