fix: fix OAuth PKCE verifier overwrite and transport authProvider lookup#19280
Open
Vishal2002 wants to merge 2 commits intoanomalyco:devfrom
Open
fix: fix OAuth PKCE verifier overwrite and transport authProvider lookup#19280Vishal2002 wants to merge 2 commits intoanomalyco:devfrom
Vishal2002 wants to merge 2 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found one potentially related PR: PR #18674 - "fix: vendor Anthropic OAuth plugin and fix PKCE state security issue (fixes #18652)" This PR also addresses PKCE-related security issues in the OAuth flow, though it focuses on a different issue (#18652 vs #17822). Both PRs involve OAuth PKCE fixes, so there's a chance of overlap in the areas being modified. |
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Vishal2002
force-pushed
the
fix/mcp-oauth-nonstandard-error-response
branch
from
0ad3cbf to
8e0a0d7
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17822
Type of change
What does this PR do?
Fixes an issue where OAuth remained stuck in
needs_authafter a successful login.saveCodeVerifiercalls causinginvalid_grantauthProvideraccess (_authProvider)How did you verify your code works?
Tested locally with Notion MCP and Atlassian MCP.
OAuth flow completes successfully, tokens persist, and client is reused across runs.
Screenshots / recordings
N/A
Checklist