fix(opencode): allow tool hooks to replace call arguments#20009
Open
phuctm97 wants to merge 3 commits intoanomalyco:devfrom
Open
fix(opencode): allow tool hooks to replace call arguments#20009phuctm97 wants to merge 3 commits intoanomalyco:devfrom
phuctm97 wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20013
Type of change
What does this PR do?
This fixes how tool execution hooks handle call arguments.
tool.execute.beforereceives an output object withargs, but the wrapper was still executing the tool with the originalargsvariable. That meant a hook could mutate an existing object in place, but it could not replace missing args with a new object.This change normalizes missing args to
{}before the hook runs, then executes the tool with the possibly replacedoutput.args. The regression tests cover both native tools and MCP tools when the original call args are undefined.How did you verify your code works?
bun test test/session/tool-hooks.test.tsbun run typecheckScreenshots / recordings
Not applicable.
Checklist