fix: support ACP question prompts via extMethod#20015
Closed
hikaruczl wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: support ACP question prompts via extMethod#20015hikaruczl wants to merge 1 commit intoanomalyco:devfrom
hikaruczl wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
github-actions
bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found a related PR:
|
Author
|
Closing this fork PR; opening the same changes against sst/opencode instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- gate ACP question support on both \ and a client-advertised \ capability\n- bridge internal \ events to ACP clients over \ and reply/reject through the existing question API\n- document the extension contract and cover the new flow in ACP event-subscription tests\n\n## Validation\n- bun test ./test/acp/event-subscription.test.ts\n- bun test ./test/tool/question.test.ts\n- bun test ./test/acp/agent-interface.test.ts\n- bun run typecheck