refactor(session): simplify LLM stream by replacing queue with fromAsyncIterable#20324
Merged
refactor(session): simplify LLM stream by replacing queue with fromAsyncIterable#20324
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
jeromelau
pushed a commit
to jeromelau/opencode
that referenced
this pull request
Apr 2, 2026
vicary
pushed a commit
to vicary/opencode
that referenced
this pull request
Apr 6, 2026
balcsida
pushed a commit
to balcsida/opencode
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the LLM streaming implementation by removing the manual queue-based approach and using
Stream.fromAsyncIterabledirectly.Changes
Queue.unboundedand manual queue managementStream.fromAsyncIterableusagefromAsyncIterableThis change makes the stream handling more idiomatic and reduces potential race conditions with the queue-based approach.