fix(tui): reconstruct pasted prompt text after wide characters#20987
Open
zcarc wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): reconstruct pasted prompt text after wide characters#20987zcarc wants to merge 1 commit intoanomalyco:devfrom
zcarc wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found a potentially related PR: Related PR:
The PR #20987 appears to be a more recent fix that addresses a similar but distinct issue: while #17034 handled pasted preview replacement for multi-width characters, #20987 specifically fixes the prompt reconstruction after pasted text summaries when wide characters appear before the pasted content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20986
Type of change
What does this PR do?
Fixes a prompt reconstruction bug in the TUI when multiline pasted text is summarized and the prompt contains wide characters before the pasted token.
Before this change, the submit path used terminal-width offsets as JavaScript string indices when expanding
[Pasted ~N lines]back into the original text. That caused the submitted prompt to be corrupted for Korean characters.This change converts width-based extmark offsets to string indices before reconstructing the final prompt text, so the pasted content and trailing input are restored in the correct position.
How did you verify your code works?
Screenshots / recordings
Checklist