Skip to content

fix(session): use parentID instead of timestamp for loop exit condition #21294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YLRong wants to merge 1 commit into from
Closed

fix(session): use parentID instead of timestamp for loop exit condition #21294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/opencode/src/session/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,14 @@ NOTE: At any point in time through this workflow you should feel free to ask the
lastAssistant?.finish &&
!["tool-calls"].includes(lastAssistant.finish) &&
!hasToolCalls &&
lastUser.id < lastAssistant.id
(
// Use parentID to determine if assistant message is a response to the last user message.
// This is more reliable than timestamp comparison when client/server clocks are out of sync.
lastAssistant.parentID === lastUser.id ||
// Fallback to timestamp comparison for backward compatibility with messages
// that may not have parentID set.
(!lastAssistant.parentID && lastUser.id < lastAssistant.id)
)
) {
log.info("exiting loop", { sessionID })
break
Expand Down
Loading