Skip to content

fix: Sub-Agent permissions override #21540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nightguarder wants to merge 2 commits into from
+9 −3
Closed

fix: Sub-Agent permissions override #21540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e6811
add parentpermissions to sub-agent
nightguarder Apr 8, 2026
3daa6fa
Merge branch 'dev' into fix/6527-subagent-permissions
nightguarder Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/opencode/src/session/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,13 +1311,15 @@ NOTE: At any point in time through this workflow you should feel free to ask the
const message = yield* createUserMessage(input)
yield* sessions.touch(input.sessionID)

const sessionPerms = session.permission ?? []
const permissions: Permission.Ruleset = []
for (const [t, enabled] of Object.entries(input.tools ?? {})) {
permissions.push({ permission: t, action: enabled ? "allow" : "deny", pattern: "*" })
}
if (permissions.length > 0) {
session.permission = permissions
yield* sessions.setPermission({ sessionID: session.id, permission: permissions })
const merged = Permission.merge(sessionPerms, permissions)
if (merged.length > 0) {
session.permission = merged
yield* sessions.setPermission({ sessionID: session.id, permission: merged })
}

if (input.noReply === true) return message
Expand Down
4 changes: 4 additions & 0 deletions packages/opencode/src/tool/task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ export const TaskTool = Tool.define("task", async () => {
const hasTaskPermission = agent.permission.some((rule) => rule.permission === "task")
const hasTodoWritePermission = agent.permission.some((rule) => rule.permission === "todowrite")

const parent = await Session.get(ctx.sessionID).catch(() => {})
const parentPerms = parent?.permission ?? []

const session = await iife(async () => {
if (params.task_id) {
const found = await Session.get(SessionID.make(params.task_id)).catch(() => {})
Expand All @@ -66,6 +69,7 @@ export const TaskTool = Tool.define("task", async () => {
parentID: ctx.sessionID,
title: params.description + ` (@${agent.name} subagent)`,
permission: [
...parentPerms,
...(hasTodoWritePermission
? []
: [
Expand Down
Loading