Skip to content

fix(tool): coerce object arguments to string in edit and write tools #21713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
extrasmall0 wants to merge 1 commit into
base: dev
Choose a base branch
from
+18 −3
Open

fix(tool): coerce object arguments to string in edit and write tools #21713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/opencode/src/tool/edit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,18 @@ export const EditTool = Tool.define("edit", {
description: DESCRIPTION,
parameters: z.object({
filePath: z.string().describe("The absolute path to the file to modify"),
oldString: z.string().describe("The text to replace"),
newString: z.string().describe("The text to replace it with (must be different from oldString)"),
oldString: z
.preprocess(
(v) => (v !== null && typeof v === "object" ? JSON.stringify(v, null, 2) : v),
z.string(),
)
.describe("The text to replace"),
newString: z
.preprocess(
(v) => (v !== null && typeof v === "object" ? JSON.stringify(v, null, 2) : v),
z.string(),
)
.describe("The text to replace it with (must be different from oldString)"),
replaceAll: z.boolean().optional().describe("Replace all occurrences of oldString (default false)"),
}),
async execute(params, ctx) {
Expand Down
7 changes: 6 additions & 1 deletion packages/opencode/src/tool/write.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,13 @@ const MAX_PROJECT_DIAGNOSTICS_FILES = 5
export const WriteTool = Tool.define("write", {
description: DESCRIPTION,
parameters: z.object({
content: z.string().describe("The content to write to the file"),
filePath: z.string().describe("The absolute path to the file to write (must be absolute, not relative)"),
content: z
.preprocess(
(v) => (v !== null && typeof v === "object" ? JSON.stringify(v, null, 2) : v),
z.string(),
)
.describe("The content to write to the file"),
}),
async execute(params, ctx) {
const filepath = path.isAbsolute(params.filePath) ? params.filePath : path.join(Instance.directory, params.filePath)
Expand Down
Loading