fix windows e2e backend not stopping on sigterm waiting 10s for no reason#21781
Merged
Hona merged 1 commit intoanomalyco:devfrom Apr 10, 2026
Merged
fix windows e2e backend not stopping on sigterm waiting 10s for no reason#21781Hona merged 1 commit intoanomalyco:devfrom
Hona merged 1 commit intoanomalyco:devfrom
Conversation
Hona
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the e2e backend shutdown logic to correctly detect processes that have already exited due to SIGTERM (notably on Windows), avoiding an unnecessary wait + forced SIGKILL.
Changes:
- Add a helper to treat
signalCode-only exits as “already stopped”. - Use the new predicate in
waitExit()andstop()to skip redundant termination steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+47
to
+49
| function done(proc: ReturnType<typeof spawn>) { | ||
| return proc.exitCode !== null || proc.signalCode !== null | ||
| } |
There was a problem hiding this comment.
The helper name done is pretty generic and doesn’t communicate that it specifically means “child process has exited” (exitCode or signalCode is set). Consider renaming to something more explicit (e.g. hasExited / isStopped) to make the stop logic easier to read/maintain.
Hona
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGTERMwith onlysignalCodeset as already stoppedSIGKILLpath on Windows when the process already exited cleanlyValidation