Skip to content

refactor(effect): use SessionRevert service in prompt#21796

Merged
kitlangton merged 2 commits intodevfrom
prompt-revert-direct-service
Apr 10, 2026
Merged

refactor(effect): use SessionRevert service in prompt#21796
kitlangton merged 2 commits intodevfrom
prompt-revert-direct-service

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • replace the remaining SessionPrompt -> SessionRevert.cleanup(...) facade hop with direct SessionRevert.Service usage
  • provide SessionRevert.defaultLayer where SessionPrompt is composed, including manual session test layer stacks
  • replace lazy Layer.unwrap(Effect.sync(() => ...)) wrappers with Layer.suspend(() => ...) in the prompt/session stack and tool registry

Notes

  • SessionPrompt.cancel(...) in tool/task.ts still stays on the facade path because a direct SessionPrompt.Service dependency there would create a SessionPrompt -> ToolRegistry -> TaskTool -> SessionPrompt cycle

Testing

  • bun typecheck
  • bun turbo typecheck
  • bun run test -- test/session/prompt-effect.test.ts test/session/snapshot-tool-race.test.ts

@kitlangton kitlangton marked this pull request as ready for review April 10, 2026 02:20
@kitlangton kitlangton enabled auto-merge (squash) April 10, 2026 02:26
@kitlangton kitlangton disabled auto-merge April 10, 2026 02:28
@kitlangton kitlangton merged commit eca11ca into dev Apr 10, 2026
8 of 9 checks passed
@kitlangton kitlangton deleted the prompt-revert-direct-service branch April 10, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant