Skip to content

refactor(effect): use Git service in file and storage#21803

Merged
kitlangton merged 1 commit intodevfrom
git-direct-service-sweep
Apr 10, 2026
Merged

refactor(effect): use Git service in file and storage#21803
kitlangton merged 1 commit intodevfrom
git-direct-service-sweep

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

Summary

  • replace remaining internal Git.run(...) facade hops in FileWatcher, Storage migrations, and File with direct Git.Service usage
  • keep the new git requirements at the correct composition boundary by updating the affected default layers and manual test layers
  • simplify File's internal git usage with a small local gitText helper and by reusing git.show(...) for original file content

Notes

  • file/index.ts was the trickiest file in this sweep because its old Effect.promise(async () => ...) blocks mixed git subprocess calls with non-git file-content work. The fix was to pull only the git subprocess pieces into Git.Service while leaving the rest of the file-content logic unchanged.
  • I reviewed the diff for simplification after the first pass. I kept the worthwhile local cleanups, but did not broaden this PR into larger reuse changes like switching storage migration identity logic over to Project or changing file status behavior more aggressively.

Testing

  • bun typecheck
  • bun turbo typecheck
  • bun run test -- test/storage/storage.test.ts test/file/watcher.test.ts

@kitlangton kitlangton marked this pull request as ready for review April 10, 2026 02:46
@kitlangton kitlangton merged commit 91786d2 into dev Apr 10, 2026
12 of 13 checks passed
@kitlangton kitlangton deleted the git-direct-service-sweep branch April 10, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant