tweak: adjust light/dark theme toggle #5007
Conversation
Rename the `Switch to light/dark mode` command to just `Toggle appearance`. Also close the command palette after actioning the command.
There was a problem hiding this comment.
Pull request overview
This PR simplifies the theme toggle command by renaming it from "Switch to light/dark mode" (which displayed the target mode dynamically) to the simpler "Toggle appearance". The change also ensures the command palette closes after toggling the theme, aligning behavior with other toggle commands like "Toggle debug panel" and "Toggle console".
Key changes:
- Renamed command title to "Toggle appearance" for clarity and simplicity
- Added
dialog.clear()call to close the palette after theme toggle
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
nit: but I don't know if I like the wording of Toggle Appearance, could we make it more like Toggle Light or Toggle Dark, idk the standard terminology there |
|
"Appearance" is what Apple calls light vs dark mode, and I was going for a single word. I believe Windows, and possibly Ubuntu, use a "Dark mode" toggle to switch modes. How about "Toggle Dark Mode"? One of the goals was to have a static menu item rather than one that changed its wording based on the mode. A menu item that changes its wording is a bit harder to search for and to find at a glance. |
That's a good point |
The main change is simply to rename the "Switch to light/dark mode" command to just "Toggle appearance". This more closely matches what the command currently does -- it doesn't let you choose the mode, it just toggles it.
This PR also updates the toggle command to close the palette after auctioning the command, which is consistent with how other commands behave.