Add session position indicator in header and refactor sibling logic#5309
Add session position indicator in header and refactor sibling logic#5309terakael wants to merge 1 commit intoanomalyco:devfrom
Conversation
|
@rekram1-node any chance of a review on this? Relatively minor change for a pretty convenient feature |
cee6fbd to
d516ff1
Compare
|
/review |
|
lgtm |
|
Hmm this PR merged last night has slightly modified the logic: #5680 The PR changed the ordering to be backwards and I'm trying to understand why - it felt fine to me previously. But the merge has made it so the parent node is now N/N instead of 1/N. I can modify the logic of this PR to reflect the ordering change, but I want to get a better understanding of why it changed before I do that. Until then I don't think this is ready to merge |
|
On my quick investigation: PR #5680 changed subagent navigation from chronological (oldest→newest) to reverse-chronological (newest→oldest). Before the merge:
Now:
I understand the idea of switching from main directly to the newest agent by pressing right, as it's likely the most relevant. It sort of breaks my mental model of having a list of agents though where right moves forward in time - maybe it's personal preferene. Which navigation order provides better UX I wonder? Personally I prefer the previous logic. |
d516ff1 to
8b6f1ff
Compare
- Add [current/total] indicator in session header to show position among siblings - Extract sibling-finding logic into sync.session.siblings() helper - Use descending sort (chronological order: main, sub1, sub2, ...) - Navigation: shift-right goes main → sub1 → sub2 → main - Display: main shows [1/N], first subagent [2/N], etc. This reverts the navigation order change from PR anomalyco#5680 (commit 1b39199) which had reversed subagent navigation to newest-to-oldest. The original chronological ordering is more intuitive for tracking subagent hierarchy.
c5c9d34 to
47a5bfa
Compare
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
I often get lost when switching between subagents. This just adds a simple indicator so that we can see at a glance where we're at.