Add timeout for file watcher subscribe to address hangs on Rosetta x86 emulation#5350
Closed
matthewijordan wants to merge 4 commits intoanomalyco:devfrom
Closed
Add timeout for file watcher subscribe to address hangs on Rosetta x86 emulation#5350matthewijordan wants to merge 4 commits intoanomalyco:devfrom
matthewijordan wants to merge 4 commits intoanomalyco:devfrom
Conversation
Collaborator
|
/review |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Collaborator
|
/review |
Contributor
|
lgtm |
2 tasks
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal Reproduction Steps
Environment
Dockerfile
Steps to Reproduce
Root Cause
@parcel/watcher'ssubscribe()function hangs under Rosetta x86_64 emulation. Wheninotify_init1()fails or behaves unexpectedly under Rosetta, the watcher'sBackend::runblocks forever instead of propagating the error (see parcel-bundler/watcher#159).This blocks the event loop, causing all subsequent async operations to hang - including file reads needed to load session data.
Verified