Closed
Conversation
added 12 commits
December 18, 2025 14:25
- Move vault key from config/ to data/ for backup locality - Extract parseRetryAfterMs and cooldown constants to util/http.ts - Add type guards in credentials/guards.ts to replace unsafe casts - Add OAuth placeholder comments to all 6 provider adapters - Add Bun dependency comment to store.ts glob usage - Update RFC with backup guidance and key rotation docs
Tests that when first credential returns 401, the rotation engine falls back to the next credential and updates health metrics.
This was referenced Dec 18, 2025
Closed
Closed
Author
|
Context: #5748. Heads-up: these auth-v2 PRs are stacked in my fork, so GitHub will show the full diff vs For just the incremental changes in this PR (on top of auth-v2 core), you can use:
If you prefer a single diff to review, #5746 is the combined PR. |
Author
|
Superseded by #5754 (focused multi-account OAuth subscription failover using Bun.secrets). Closing to reduce noise; happy to reopen if you want the broader scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #5748.
Builds on auth v2 core branch
jroth1111:auth-v2-core(RFC:specs/provider-auth-v2.md).Summary
Adds a TUI "connected accounts" manager and basic rotation instrumentation so users can see/manage stored credentials and quickly diagnose same-request OAuth rotation behavior.
What changed
r) and delete (d).RotationStats) + server/debug/rotationendpoint.How to test