feat(keybinds): support physical keycode-based keybindings for non-English layouts#6753
Open
wanbok wants to merge 1 commit intoanomalyco:devfrom
Open
feat(keybinds): support physical keycode-based keybindings for non-English layouts#6753wanbok wants to merge 1 commit intoanomalyco:devfrom
wanbok wants to merge 1 commit intoanomalyco:devfrom
Conversation
Add support for physical key position matching in keybindings, enabling shortcuts to work correctly with non-English keyboard layouts (Korean, Japanese, Chinese, AZERTY, Dvorak, etc.). - Add baseCode to Keybind.Info type - Update Keybind.match() with usePhysicalKeys option - Add usePhysicalKeys config option (opt-in, default false) - Add 18 tests for physical key matching - Graceful fallback for terminals without Kitty protocol
This was referenced Jan 6, 2026
This was referenced Jan 13, 2026
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Support physical keycode-based keybindings for non-English keyboard layouts
Summary
Add support for physical key position matching in keybindings, enabling shortcuts to work correctly with non-English keyboard layouts (Korean, Japanese, Chinese, AZERTY, Dvorak, etc.).
Problem
When using non-English input methods, keybindings fail because OpenCode matches by character name:
ctrl+xCtrl + X keyproducesctrl+ㅌSolution
Leverage OpenTUI's existing Kitty keyboard protocol support (
baseCodefield) for physical key matching.Changes
src/util/keybind.tsbaseCodetoInfotype, updatematch()withMatchOptionssrc/cli/cmd/tui/context/keybind.tsxusePhysicalKeysconfig tomatch()src/config/config.tsusePhysicalKeyskeybind optiontest/keybind.test.tsUsage
{ "keybinds": { "usePhysicalKeys": true } }Compatibility
falsefor backward compatibilitybaseCodeunavailableTesting
Added tests for:
Related