feat: update BashTool command parsing logic#6948
Closed
RinZ27 wants to merge 1 commit intoanomalyco:devfrom
Closed
feat: update BashTool command parsing logic#6948RinZ27 wants to merge 1 commit intoanomalyco:devfrom
RinZ27 wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Duplicate PR Search ResultsNo duplicate PRs found. ✓ The search results only returned the PR itself (PR #6948), which is expected. Additional searches for related security and validation terms yielded no other open PRs addressing:
Conclusion: This PR appears to be unique and is not duplicating any existing open pull requests in the repository. |
09e4a65 to
c6e3a8c
Compare
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
c7a6121 to
fd0af82
Compare
8df4f17 to
b03ff60
Compare
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
2e4349d to
cb3320f
Compare
cb3320f to
88ff70b
Compare
5 tasks
6 tasks
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refined the command parsing logic in BashTool by adding a check for empty command arrays during tree-sitter traversal. This prevent processing malformed shell structures that could lead to unexpected execution behavior.
Security Risk: Potential for command injection or agent escape if malformed input nodes are processed without validation.
Fixes #7478
Fixes #7504