fix: Enhance clipboard error handling by propagating errors and checking command exit codes#7220
Closed
ErvisTusha wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: Enhance clipboard error handling by propagating errors and checking command exit codes#7220ErvisTusha wants to merge 1 commit intoanomalyco:devfrom
ErvisTusha wants to merge 1 commit intoanomalyco:devfrom
Conversation
… command exit codes, and providing specific messages when tools are missing.
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found two related PRs that may be duplicate or closely related to PR #7220: Potential Related PRs:
These PRs may have overlapping changes to the clipboard implementation or could be addressing the same underlying issues. I recommend reviewing these PRs to ensure there are no conflicting changes or duplicated efforts. |
Author
|
fixed for 1.1.6 Linux/Ubuntu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request improves clipboard functionality by enhancing error handling across all platforms, with particular focus on Linux systems. The changes ensure that clipboard operations properly propagate errors and provide meaningful feedback to users when issues occur.
Changes
1. Clipboard.ts (util/clipboard.ts)
WAYLAND_DISPLAYenvironment variablewl-copy(Wayland)xclip(X11)xsel(X11)2. App.tsx (ui/app.tsx)
Technical Details
.catch(() => {})(silent failures) to.catch((error) => { ... })(proper error handling)Testing
Related Issues
Closes #[issue-number] (if applicable)
Checklist