Merged
Conversation
edegenetais-nx
force-pushed
the
feature/24_add_missing_id_types
branch
from
87be4bc to
1facc27
Compare
bou3108
approved these changes
May 17, 2024
Collaborator
bou3108
left a comment
bou3108
left a comment
There was a problem hiding this comment.
LGTM
côté psc-api, l'idType est simplement de type String.
Il faudrait peut-être envisager de le durcir à terme dans l'API (donc dans le client utilisé par rass-loader) ?
Contributor
Author
Hello ! Oui, ce serait bien. On manque un peu de temps là malheureusement => je crée une fiche sur l'API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24