Merged
Conversation
josevalim
reviewed
Jun 25, 2018
| end | ||
|
|
||
| test "Tensor Functionalities Test" do | ||
| dims = Tensorflex.create_matrix(1,3,[[1,1,3]]) |
Contributor
There was a problem hiding this comment.
Prefer to pattern match here. For example: {:ok, dims} = .... We rarely use elem in Elixir code.
josevalim
reviewed
Jun 25, 2018
| use ExUnit.Case | ||
| doctest Tensorflex | ||
|
|
||
| test "Matrix Functionalities Test" do |
Contributor
There was a problem hiding this comment.
It is generally bad practice to have such large tests. Instead you want to do this:
describe "matrix functionalities" do
test "creates matrixes" do
...
end
test "can get size of matrix" do
...
end
...
end
josevalim
reviewed
Jun 25, 2018
|
|
||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
There are a bunch of unnecessary extra new lines here. :)
Owner
Author
|
Noted @josevalim! I will be sure to fix these issues in the next PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.