Add plugin for Azure VM managed identity#106
Merged
jessicamack merged 3 commits intoMay 6, 2025
Merged
Conversation
webknjaz
reviewed
Apr 14, 2025
webknjaz
reviewed
Apr 14, 2025
webknjaz
reviewed
Apr 14, 2025
webknjaz
reviewed
Apr 15, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
webknjaz
reviewed
Apr 17, 2025
Member
|
Unrelated linkcheck failure: #107 |
6c40bbe to
001bcb0
Compare
webknjaz
reviewed
Apr 23, 2025
webknjaz
reviewed
Apr 23, 2025
webknjaz
reviewed
Apr 23, 2025
webknjaz
reviewed
Apr 23, 2025
Member
webknjaz
left a comment
There was a problem hiding this comment.
Found a few things to delete.
webknjaz
reviewed
May 5, 2025
webknjaz
reviewed
May 5, 2025
webknjaz
reviewed
May 5, 2025
webknjaz
reviewed
May 5, 2025
webknjaz
reviewed
May 5, 2025
webknjaz
reviewed
May 5, 2025
webknjaz
reviewed
May 5, 2025
ed0ce04 to
8d69ceb
Compare
It was previously global and now ignore only one import. Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Now azure_kv should try the original way to authenticate and if all the fields are not provided it will fallback to attempting to authenticate using the Managed Identity method. This patch includes full test coverage for the newly added code.
8d69ceb to
85c96f9
Compare
webknjaz
approved these changes
May 6, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a plugin that uses Managed Identities for Azure resources on an Azure VM to authenticate and retrieve secrets from an Azure Key Vault. This is similar to how the existing Azure Key Vault plugin works but it does not require Client ID, Client Secret, or Tenant ID. When run in an Azure VM the identity of the VM will be picked up and used as the credential to authenticate to the Key Vault. The only requirements then are the Vault URL, the name of the secret to retrieve, optionally the version of the secret to retrieve, and for the VM itself to be given the correct Key Vault Administrator role.