[AAP-72722] Remove jwt_aud field from OIDC-enabled credential plugins#181
Conversation
Plugin hosts will be using the `url` field when requesting tokens as a more appropriate value. The `jwt_aud` becomes unused, so it is removed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR removes the JWT Audience field ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I see that a 3.14 lint check and pre-commit.ci check are failing with the same issue on |
Related: |
Signed-off-by: yoonhyunwoo <yjs88zerg@gmail.com>
Plugin hosts will be using the
urlfield when requesting tokens as a more appropriate value. Thejwt_audbecomes unused, so it is removed.For https://redhat.atlassian.net/browse/AAP-72722
Related: ansible/awx#16432
Summary by CodeRabbit