Skip to content
This repository was archived by the owner on Sep 16, 2020. It is now read-only.

Conversation

@AlanCoding
Copy link
Member

Connect #356

This was not at all as easy as I had imagined, but I am pretty sure this works. As a general method, it also probably could some some other yet-undiscovered bugs as data is modified in special-cases.

I worry that this isn't quite the right way to go. It doesn't allow specifying multi-line inputs of arbitrary fields, which could matter for custom credentials. We could do this with click with a single new field that allows arbitrary input like the --query parameter. Say:

tower-cli credential modify --name="new_cred" --subfield ssh_key_data @filename

But this raises additional question about how to determine data type. We could get the data type from the credential type input schema. I don't know if there would be much value in doing that, but it could crumble if users specified a boolean or integer.

@AlanCoding AlanCoding requested a review from phips June 13, 2018 19:27
@AlanCoding AlanCoding force-pushed the credential_shortcuts branch from 1e6931e to 9f5c6c0 Compare June 13, 2018 19:34
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 64.068% when pulling 9f5c6c0 on AlanCoding:credential_shortcuts into ade7f70 on ansible:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 64.068% when pulling 9f5c6c0 on AlanCoding:credential_shortcuts into ade7f70 on ansible:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 64.068% when pulling 9f5c6c0 on AlanCoding:credential_shortcuts into ade7f70 on ansible:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 64.068% when pulling 9f5c6c0 on AlanCoding:credential_shortcuts into ade7f70 on ansible:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants