This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Rename function isEmpty to checkIfEmpty#329
Open
jlouche wants to merge 1 commit intoansman:masterfrom
Kwixeo:master
Open
Rename function isEmpty to checkIfEmpty#329jlouche wants to merge 1 commit intoansman:masterfrom Kwixeo:master
jlouche wants to merge 1 commit intoansman:masterfrom
Kwixeo:master
Conversation
Rename function isEmpty to checkIfEmpty to avoid a javascript error after build.
The error :
Uncaught TypeError: Cannot assign to read only property 'isEmpty' of function 'function(attributes, constraints, options) {...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just rename the function isEmpty to checkIfEmpty.
If validate.js is not used directly in a project but via a library (which it uses validate.js), the following error occurs:
The problem seems to be that the isEmpty function is already defined by default as a prototype.