fix: illogic when ruleCode exists but not found in database

[Center-Sun]

Thank you for your contribution to CloudRec!

What About:

• Server (java)
• Collector (go)
• Rule (opa)

Description:

There was a logic flaw in the saveOrgRule method where rules with non-empty ruleCode but not existing in the database were being skipped during the insertion process.

Issue Details

• When ruleCode is not empty but no corresponding record exists in the database, the rule should be inserted
• However, the original logic was missing the else branch to handle this scenario
• This caused data inconsistency during initRule operations where:
  • Rule metadata was not inserted into the main rule table
  • But related data (rule types, etc.) were still processed and inserted into associated tables
  • Result: orphaned records in related tables without corresponding main rule records

Summary by Sourcery

Bug Fixes:

• Ensure rules with a non-empty ruleCode but no existing record are inserted to prevent orphaned related table entries

[gemini-code-assist]

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR amends the saveOrgRule method in RuleRepositoryImpl to insert a new rule record whenever a non‐empty ruleCode is provided but no corresponding database entry exists, closing the gap that previously led to orphaned related records.

Sequence diagram for updated saveOrgRule logic when ruleCode exists but not in database

sequenceDiagram
    participant Service as RuleRepositoryImpl
    participant DB as Database
    participant Mapper as ruleMapper
    Service->>DB: Check if ruleCode exists
    alt ruleCode exists in DB
        Service->>Mapper: updateByPrimaryKeySelective(rulePO)
    else ruleCode does not exist in DB
        Service->>Mapper: insertSelective(rulePO)
    end

Loading

Class diagram for updated RuleRepositoryImpl.saveOrgRule logic

classDiagram
    class RuleRepositoryImpl {
        +void saveOrgRule(RuleAgg ruleAgg)
    }
    class ruleMapper {
        +void updateByPrimaryKeySelective(rulePO)
        +void insertSelective(rulePO)
    }
    RuleRepositoryImpl --> ruleMapper

Loading

File-Level Changes

Change	Details	Files
Add missing else branch to insert rules with code not found in DB	Added an else block after the update branch Called ruleMapper.insertSelective(rulePO) when existRule is null	app/application/src/main/java/com/alipay/application/service/rule/domain/repo/RuleRepositoryImpl.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Center-Sun - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[j3ttt]

LGTM