Skip to content

fix(tests): suppress deprecation error of event_loop#111

Closed
natsukium wants to merge 1 commit intoanthropics:mainfrom
natsukium:fix/event_loop
Closed

fix(tests): suppress deprecation error of event_loop#111
natsukium wants to merge 1 commit intoanthropics:mainfrom
natsukium:fix/event_loop

Conversation

@natsukium
Copy link
Copy Markdown

The event_loop of pytest-asyncio should be closed explicitly, as shown in the following document.
https://github.com/pytest-dev/pytest-asyncio/tree/v0.18.3#event_loop
As of 0.18.3, which is fixed in pyproject.toml, it closes automatically, but as of 0.21.0, it throws an error.

It would be good to fix this for future updates.

@rattrayalex
Copy link
Copy Markdown
Collaborator

rattrayalex commented Aug 10, 2023

Thanks for reporting & fixing! This looks right at first blush; we'll take a deeper look at this tomorrow.

@RobertCraigie
Copy link
Copy Markdown
Collaborator

Thanks for the fix @natsukium! We've pushed a fix separately that includes your changes and also bumps pytest-asyncio to the latest version in #114.

@natsukium
Copy link
Copy Markdown
Author

thanks!

@natsukium natsukium deleted the fix/event_loop branch August 11, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants