feat(plugins): Implement severity system and add new security patterns#30305
Open
Dann1y wants to merge 4 commits intoanthropics:mainfrom
Open
feat(plugins): Implement severity system and add new security patterns#30305Dann1y wants to merge 4 commits intoanthropics:mainfrom
Dann1y wants to merge 4 commits intoanthropics:mainfrom
Conversation
…lnerability detection and severity-based responses
… patterns and severity levels
This was referenced Mar 3, 2026
Rzechol
approved these changes
Mar 3, 2026
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR transitions our security tool from a binary "block-all" approach to a nuanced 2-tier Severity System, improving developer workflow while expanding security coverage.
Solution
1. Severity System: "Block" vs "Warn"
block: Stops execution for high-risk, definite security errors (e.g., SQL Injection, Eval).warn: Provides guidance for patterns that are risky but sometimes intentional (e.g., innerHTML, child_process).2. 5 New Security Patterns
Quick File Reference
security_reminder_hook.py: Core logic for severity branching & new patterns.README.md & plugin.json: Documentation and version bump (v1.1.0).test_security_reminder_hook.py: Comprehensive test suite (70 cases).🛡️Existing Security Patterns
This table outlines the existing patterns, their severity levels, and the reasoning behind each.
github_actions_workfloweval_injectionchild_process_execnew_function_injectionreact_dangerously_set_htmldocument_write_xssinnerHTML_xsspickle_deserializationos_system_injection✨ New Security Patterns
This table details the newly added patterns and the logic used to detect them.
sql_injectionhardcoded_secretspath_traversalinsecure_deserializationyaml.loadornode-serializeunsafe_deprecated_apisnew Buffer()usageTest