Remove warnings when compiling with GCC 10.2.1 20201203 on Linux, fix #66#67
Open
AlbertoGP wants to merge 2 commits intoantirez:masterfrom
Open
Remove warnings when compiling with GCC 10.2.1 20201203 on Linux, fix #66#67AlbertoGP wants to merge 2 commits intoantirez:masterfrom
AlbertoGP wants to merge 2 commits intoantirez:masterfrom
Conversation
It is clear that the intention was to run `lua_addvalue()` only if there is no error because lua_error() “never returns” ← `load81/lua/doc/manual.html#luaL_error`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leaves only one warning:
There is a note about this in
lua/src/luaconf.h:If I understand this correctly, when running on Linux it would not use
tmpnamanyway. If so, it would be nice to quiet this warning too.