Skip to content

Fix bug in function "table_is_an_array". #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qiuyuzhou wants to merge 2 commits into from
Closed

Fix bug in function "table_is_an_array". #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dadb88
Fix bug in function "table_is_an_array".
qiuyuzhou Jul 29, 2013
51c42ad
Merge remote-tracking branch 'antirez/master'
qiuyuzhou May 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lua_cmsgpack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,13 +384,15 @@ static int table_is_an_array(lua_State *L) {
idx = n;
if (idx != n || idx < 1) goto not_array;
count++;
if ( max < idx )
max = idx;
}
/* We have the total number of elements in "count". Also we have
* the max index encountered in "idx". We can't reach this code
* the max index encountered in "max". We can't reach this code
* if there are indexes <= 0. If you also note that there can not be
* repeated keys into a table, you have that if idx==count you are sure
* repeated keys into a table, you have that if max==count you are sure
* that there are all the keys form 1 to count (both included). */
return idx == count;
return max == count;

not_array:
lua_pop(L,1);
Expand Down