feat: Add support for relative path for tflint#264
Closed
MaxymVlasov wants to merge 1 commit intomasterfrom
Closed
feat: Add support for relative path for tflint#264MaxymVlasov wants to merge 1 commit intomasterfrom
MaxymVlasov wants to merge 1 commit intomasterfrom
Conversation
Add common funtions that will be moved to separaty file in future. For DRY reason
Collaborator
Author
|
@gravitybacklight jfyi |
Collaborator
Author
|
Had a conversation with Anton about
https://github.com/terraform-linters/tflint/blob/master/docs/user-guide/config.md So that PR break that and, also, decreases exciting functional. Maybe, I will investigate |
Owner
|
@MaxymVlasov I use this hook in my precmd() {
GIT_REPO_DIR=$(git rev-parse --show-toplevel 2>/dev/null)
if [[ -n "$GIT_REPO_DIR" ]]; then
export GIT_REPO_DIR="$GIT_REPO_DIR"
fi
} |
Collaborator
jfyi, it should be safe to replace it with a oneliner: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put an
xinto the box if that apply:Description of your changes
tflint: Add relative path support.
Add common functions that will be moved to separately file in the future.
For DRY reason
Relates: #252, #255, #259, #262
How has this code been tested
Run
pre-commit run -afor each configuration. Results should be the same.