chore: Reuse logic from common functions#402
Closed
nshenry03 wants to merge 1 commit intoantonbabenko:masterfrom
Closed
chore: Reuse logic from common functions#402nshenry03 wants to merge 1 commit intoantonbabenko:masterfrom
nshenry03 wants to merge 1 commit intoantonbabenko:masterfrom
Conversation
From @MaxymVlasov in antonbabenko#401 (comment): > Heh, you found code written in Paleolithic. > > Let's try reuse logic that used in common functions here: > > https://github.com/antonbabenko/pre-commit-terraform/blob/master/hooks/_common.sh#L178 > > Absolutely have no idea why it was written in so complex way
nshenry03
changed the title
yermulnik
approved these changes
Jun 30, 2022
Collaborator
yermulnik
left a comment
yermulnik
left a comment
There was a problem hiding this comment.
If this is exactly what @MaxymVlasov meant in #401 (comment) (as opposite to re-working this hook to use common::per_dir_hook common func), then LGTM
Collaborator
|
Hmm, literally, maybe it can be rewriten to |
MaxymVlasov
added this to the
Features implementing and cleanup without breaking changes milestone
Contributor
Author
|
Sorry, @MaxymVlasov , maybe I don't understand... Do you want me to call the Just seeing if you need anything else from me. Thanks! |
Collaborator
|
Close in #404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From @MaxymVlasov in #401 (comment):
Put an
xinto the box if that apply:Description of your changes
Just doing as @MaxymVlasov asked in #401 (comment)
How can we test changes
None. It's a fairly simple and straightforward change.