Skip to content

fix: star page reset #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoncoding merged 1 commit into from
Nov 30, 2025
Merged

fix: star page reset #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions app/markets/components/markets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ export default function Markets({
}

setFilteredMarkets(sorted);
resetPage();
}, [
rawMarkets,
sortColumn,
Expand All @@ -387,14 +386,32 @@ export default function Markets({
minLiquidityEnabled,
trustedVaultsOnly,
searchQuery,
resetPage,
hasTrustedVault,
]);

useEffect(() => {
applyFiltersAndSort();
}, [applyFiltersAndSort]);

// Reset page only when filters change (not when sorting or starring changes)
useEffect(() => {
resetPage();
}, [
selectedNetwork,
includeUnknownTokens,
showUnknownOracle,
selectedCollaterals,
selectedLoanAssets,
selectedOracles,
usdFilters,
minSupplyEnabled,
minBorrowEnabled,
minLiquidityEnabled,
trustedVaultsOnly,
searchQuery,
resetPage,
]);

const titleOnclick = useCallback(
(column: number) => {
// Validate that column is a valid SortColumn value
Expand Down