hotfix: filter

[antoncoding]

Summary by CodeRabbit

• New Features

  • Added Clear button to network filter for resetting selected networks with a single click.

• Style

  • Refined padding behavior in table containers for consistent and improved spacing.
  • Enhanced filter button hover effects with smooth visual transitions.
  • Improved empty state styling with better visual hierarchy and spacing.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
monarch	Ready	Preview, Comment	Dec 28, 2025 3:38am

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR refines UI component styling and filtering behavior across multiple market-related components. It removes a conditional padding prop from TableContainerWithHeader (making padding static), updates visual styling by removing shadows and adding transition effects, and introduces a network filter clear action with an icon button.

Changes

Cohort / File(s)	Summary
Padding & Layout Refactoring src/components/common/table-container-with-header.tsx, src/components/status/empty-screen.tsx, src/features/markets/components/table/markets-table.tsx	Removed noPadding prop from TableContainerWithHeader (now always applies pb-4), removed shadow-sm from EmptyScreen outer container, and updated markets-table to apply min-height and padding to empty state
Filter UI Enhancements src/features/markets/components/filters/asset-filter.tsx, src/features/markets/components/filters/network-filter.tsx	Added transition styling to asset filter's "Clear All" button; added clearSelection function and Clear button with TrashIcon to network filter dropdown

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• refactor: local storage and props #261: Directly modifies TableContainerWithHeader's noPadding prop in the same file
• feat: table detail fixes #250: Modifies the same component's padding behavior with pb-4 addition

Suggested labels

ui

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check	❓ Inconclusive	The title 'hotfix: filter' is too vague and doesn't clearly describe what the pull request actually changes.	Use a more specific title that describes the actual changes, like 'hotfix: remove noPadding prop and update filter styling' or similar.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/network-dropdown

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0ed7ca and 54f5225.

📒 Files selected for processing (5)

• src/components/common/table-container-with-header.tsx
• src/components/status/empty-screen.tsx
• src/features/markets/components/filters/asset-filter.tsx
• src/features/markets/components/filters/network-filter.tsx
• src/features/markets/components/table/markets-table.tsx

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2024-10-12T09:23:16.495Z

Learnt from: antoncoding
Repo: antoncoding/monarch PR: 63
File: app/markets/components/MarketRowDetail.tsx:49-52
Timestamp: 2024-10-12T09:23:16.495Z
Learning: When rendering oracle feeds in `ExpandedMarketDetail` (`app/markets/components/MarketRowDetail.tsx`), prefer explicit rendering over iterating keys when dealing with a small number of feeds.

Applied to files:

• src/features/markets/components/table/markets-table.tsx

📚 Learning: 2024-12-16T02:01:51.219Z

Learnt from: antoncoding
Repo: antoncoding/monarch PR: 97
File: app/positions/components/onboarding/OnboardingContext.tsx:36-43
Timestamp: 2024-12-16T02:01:51.219Z
Learning: In `app/positions/components/onboarding/OnboardingContext.tsx`, the `defaultStep` variable is no longer needed and can be removed.

Applied to files:

• src/components/status/empty-screen.tsx

🔇 Additional comments (5)

src/components/status/empty-screen.tsx (1)

12-12: LGTM - visual polish.

Shadow removed from container. No functional changes.

src/features/markets/components/filters/asset-filter.tsx (1)

190-190: LGTM - smooth transitions added.

Hover effect improved with color transitions.

src/features/markets/components/table/markets-table.tsx (1)

198-201: LGTM - aligned with container changes.

Removed obsolete noPadding usage. EmptyScreen styling added for consistent spacing.

Also applies to: 216-216

src/features/markets/components/filters/network-filter.tsx (1)

3-3: LGTM - Clear action added.

Network filter now supports clearing selection. Implementation mirrors asset-filter pattern. Bottom panel styled correctly with pb-12 clearance.

Also applies to: 36-39, 92-133

src/components/common/table-container-with-header.tsx (1)

1-6: No other components pass the removed noPadding prop. The change is safe.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}