Skip to content

chore: filter icon#287

Merged
antoncoding merged 2 commits intomasterfrom
chore/icon
Jan 10, 2026
Merged

chore: filter icon#287
antoncoding merged 2 commits intomasterfrom
chore/icon

Conversation

@antoncoding
Copy link
Copy Markdown
Owner

@antoncoding antoncoding commented Jan 10, 2026

Summary by CodeRabbit

  • Style
    • Updated filter icons across data tables and filter modal dialogs for consistent visual design throughout the application.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jan 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
monarch Ready Ready Preview, Comment Jan 10, 2026 5:11am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 10, 2026

Warning

Rate limit exceeded

@antoncoding has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2194be2 and 67cc381.

📒 Files selected for processing (7)
  • src/features/positions/components/markets-filter-compact.tsx
  • src/features/positions/components/onboarding/setup-positions.tsx
  • src/features/positions/components/rebalance/rebalance-modal.tsx
  • src/features/rewards/rewards-view.tsx
  • src/hooks/useBorrowTransaction.ts
  • src/modals/borrow/components/add-collateral-and-borrow.tsx
  • src/modals/borrow/components/withdraw-collateral-and-repay.tsx
📝 Walkthrough

Walkthrough

Replaces filter and slider icons across market detail and position components, swapping from FiFilter/FiSliders (react-icons/fi) to GoFilter (react-icons/go). Only visual changes; no functional or logic modifications.

Changes

Cohort / File(s) Summary
Market Detail Table Components
src/features/market-detail/components/borrowers-table.tsx, borrows-table.tsx, suppliers-table.tsx, supplies-table.tsx
Replaced FiFilter import and usage with GoFilter in tooltip and button elements
Market Detail Filter Modals
src/features/market-detail/components/filters/borrower-filters-modal.tsx, supplier-filters-modal.tsx
Replaced FiSliders with GoFilter in modal header mainIcon
Position Filter Component
src/features/positions/components/markets-filter-compact.tsx
Replaced FiFilter with GoFilter across tooltip, button, and modal icons

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

ui

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'chore: filter icon' is vague and doesn't specify what changed. It doesn't clarify whether icons were added, removed, or replaced. Be more specific: e.g., 'chore: replace filter icons with GoFilter' or 'chore: update filter icons to react-icons/go'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the ui User interface label Jan 10, 2026
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Jan 10, 2026

Greptile Overview

Greptile Summary

This PR updates filter icons across market detail and position components, replacing Feather Icons (FiFilter and FiSliders) with Github Octicons (GoFilter) for visual consistency.

Changes Made

The PR updates 7 files to use GoFilter from react-icons/go:

  • Table components: borrowers-table.tsx, borrows-table.tsx, suppliers-table.tsx, supplies-table.tsx - replaced FiFilter with GoFilter
  • Filter modals: borrower-filters-modal.tsx, supplier-filters-modal.tsx - replaced FiSliders with GoFilter
  • Filter component: markets-filter-compact.tsx - replaced FiFilter with GoFilter

All icon usages maintain consistent sizing (14px for tooltips/buttons, 16px for larger buttons) and conditional coloring based on active filter states.

Issues Found

Syntax Issue: The import statement in markets-filter-compact.tsx uses double quotes instead of single quotes, which is inconsistent with the codebase's import convention.

Note on Incomplete Migration

The transaction-filters-modal.tsx file still uses FiSliders and was not updated in this PR. This creates a minor inconsistency where borrower/supplier filter modals use GoFilter but the transaction filter modal uses FiSliders. This may be intentional to distinguish different types of filters, but should be verified.

Confidence Score: 4/5

  • This PR is safe to merge with one minor syntax fix required
  • Score reflects a straightforward icon replacement PR with minimal risk. The changes are cosmetic and don't affect functionality. One syntax issue (inconsistent quote style) needs correction before merge, but this is a trivial fix that won't impact runtime behavior. All icon replacements are correctly implemented with proper sizing and conditional styling preserved.
  • Pay attention to markets-filter-compact.tsx which has an import syntax inconsistency that needs correction

Important Files Changed

File Analysis

Filename Score Overview
src/features/market-detail/components/filters/borrower-filters-modal.tsx 5/5 Clean icon replacement from FiSliders to GoFilter with correct syntax
src/features/market-detail/components/filters/supplier-filters-modal.tsx 5/5 Clean icon replacement from FiSliders to GoFilter with correct syntax
src/features/positions/components/markets-filter-compact.tsx 4/5 Icon replacement from FiFilter to GoFilter, but import uses inconsistent double quotes instead of single quotes

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread src/features/positions/components/markets-filter-compact.tsx
@antoncoding antoncoding merged commit ce4e3e6 into master Jan 10, 2026
4 checks passed
@antoncoding antoncoding deleted the chore/icon branch January 10, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui User interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant