feat: notifications for new features#361
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds two active global notifications, updates banner layout/styling (uses GridAccent, overflow-hidden, button z-index), tweaks hero z-index, and switches notification dismissal checks to use a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/config/notifications.ts`:
- Around line 47-48: Replace the ambiguous UTC-midnight construction for the
expiresAt property with an explicit end-of-day UTC timestamp for 2026-02-16
(i.e., set expiresAt to the UTC 23:59:59 end-of-day value rather than new
Date('2026-02-16')), and apply the same change to the other expiresAt
occurrence; update the expiresAt properties so they are timezone-safe (explicit
UTC end-of-day) to prevent premature expiry in US time zones.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/config/notifications.ts`:
- Line 43: The expiresAt date in the notification/banner configuration (property
expiresAt in src/config/notifications.ts) is set to 2026-02-10 but the PR
description specifies 2026-02-16; update the expiresAt value to match the PR
(set expiresAt to new Date('2026-02-16')) so the banner expiration aligns with
the PR intention and any related tests/docs.
| message: '💎 New feature: Position History Graph — analyze any account\'s allocation changes over time!', | ||
| type: 'info', | ||
| category: 'global', | ||
| expiresAt: new Date('2026-02-10'), |
There was a problem hiding this comment.
Date mismatch with PR description.
PR says banners expire Feb 16, but code has Feb 10. Which is correct?
🤖 Prompt for AI Agents
In `@src/config/notifications.ts` at line 43, The expiresAt date in the
notification/banner configuration (property expiresAt in
src/config/notifications.ts) is set to 2026-02-10 but the PR description
specifies 2026-02-16; update the expiresAt value to match the PR (set expiresAt
to new Date('2026-02-16')) so the banner expiration aligns with the PR intention
and any related tests/docs.
Adds 2 notification banners for newly shipped features:
Both expire in 2 weeks (Feb 16).
Dismissing one smoothly reveals the next (existing behavior via
1/2badge).Summary by CodeRabbit