Skip to content

feat: notifications for new features#361

Merged
antoncoding merged 5 commits intomasterfrom
feat/new-feature-notifications
Feb 2, 2026
Merged

feat: notifications for new features#361
antoncoding merged 5 commits intomasterfrom
feat/new-feature-notifications

Conversation

@starksama
Copy link
Copy Markdown
Collaborator

@starksama starksama commented Feb 2, 2026

Adds 2 notification banners for newly shipped features:

  1. Position History Chart — guides users to /positions
  2. Custom Tags — mentions Settings → Experimental, links to /markets

Both expire in 2 weeks (Feb 16).

Dismissing one smoothly reveals the next (existing behavior via 1/2 badge).

Summary by CodeRabbit

  • New Features
    • Added two active global notifications that appear across the app (message, type, category and expiration). No changes to public APIs or exported signatures.
  • Bug Fixes / UI
    • Improved banner visuals and layering so background accents and the close button display correctly.
    • Fixed hero content layering to ensure correct stacking with the banner.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
monarch Ready Ready Preview, Comment Feb 2, 2026 10:10am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Adds two active global notifications, updates banner layout/styling (uses GridAccent, overflow-hidden, button z-index), tweaks hero z-index, and switches notification dismissal checks to use a dismissedIds array lookup. No exported/public signatures changed. (≤50 words)

Changes

Cohort / File(s) Summary
Notifications config
src/config/notifications.ts
Replaced commented example with two active global notification entries (id, message, type, category, expiresAt). No API/signature changes.
Notification banner & layout
src/components/layout/notification-banner.tsx, src/features/home/home-view.tsx
Banner: replaced static overlay with GridAccent (position="top-strip", variant="dots", opacity reduced), added overflow-hidden and raised close-button z-index; Home view: added relative z-10 to hero container.
Notification logic
src/hooks/useActiveNotifications.ts
Replaced isDismissed checks with dismissedIds.includes(notification.id), renamed local state to dismissedIds, and updated memo dependency to [dismissedIds, conditions].

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change—adding notifications for new features. The code shows exactly this: two new active notifications and supporting UI updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/new-feature-notifications

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the ui User interface label Feb 2, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/config/notifications.ts`:
- Around line 47-48: Replace the ambiguous UTC-midnight construction for the
expiresAt property with an explicit end-of-day UTC timestamp for 2026-02-16
(i.e., set expiresAt to the UTC 23:59:59 end-of-day value rather than new
Date('2026-02-16')), and apply the same change to the other expiresAt
occurrence; update the expiresAt properties so they are timezone-safe (explicit
UTC end-of-day) to prevent premature expiry in US time zones.

Comment thread src/config/notifications.ts Outdated
Copy link
Copy Markdown
Owner

@antoncoding antoncoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/config/notifications.ts`:
- Line 43: The expiresAt date in the notification/banner configuration (property
expiresAt in src/config/notifications.ts) is set to 2026-02-10 but the PR
description specifies 2026-02-16; update the expiresAt value to match the PR
(set expiresAt to new Date('2026-02-16')) so the banner expiration aligns with
the PR intention and any related tests/docs.

message: '💎 New feature: Position History Graph — analyze any account\'s allocation changes over time!',
type: 'info',
category: 'global',
expiresAt: new Date('2026-02-10'),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Date mismatch with PR description.

PR says banners expire Feb 16, but code has Feb 10. Which is correct?

🤖 Prompt for AI Agents
In `@src/config/notifications.ts` at line 43, The expiresAt date in the
notification/banner configuration (property expiresAt in
src/config/notifications.ts) is set to 2026-02-10 but the PR description
specifies 2026-02-16; update the expiresAt value to match the PR (set expiresAt
to new Date('2026-02-16')) so the banner expiration aligns with the PR intention
and any related tests/docs.

@antoncoding antoncoding merged commit 24e13d0 into master Feb 2, 2026
4 checks passed
@antoncoding antoncoding deleted the feat/new-feature-notifications branch February 2, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui User interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants