fix: markets loading state uses full width to align with filters#374
Merged
antoncoding merged 1 commit intomasterfrom Feb 7, 2026
Merged
fix: markets loading state uses full width to align with filters#374antoncoding merged 1 commit intomasterfrom
antoncoding merged 1 commit intomasterfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe MarketsTable component's className construction logic was refactored. Instead of concatenating conditional classes with the provided className, it now builds an array that includes a default 'w-full' class, conditionally adds 'items-center', and filters empty values before joining. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the markets view is loading, the loading card had adaptive width, causing misalignment with the filter bar.
Solution
Changed the
containerClassNamelogic to always use the passedclassNameprop (defaults tow-full) instead of replacing it withcontainer items-centerduring loading states.Before: Loading state replaces
className→ width inconsistencyAfter: Loading state keeps
className+ addsitems-center→ consistent full widthSummary by CodeRabbit
Release Notes