-
Notifications
You must be signed in to change notification settings - Fork 3
feat: smart rebalance #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
98597e8
Initial rebalancing button
secretmemelocker fe9f68a
Make rebalance work
secretmemelocker 4b74fed
Add smart rebalance button
secretmemelocker b079610
Code rabbit fixes by Claude
secretmemelocker e82c053
Proper permit 2 timing check and add back owner gate
secretmemelocker d1df7d4
feat: apply optimizer rebalancing workflow
antoncoding 8191ffb
chore: always show preview
antoncoding 292ddbc
chore: reivew fixes
antoncoding 10bba05
chore: review fixes
antoncoding 47a04a1
chore: fix dust
antoncoding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { type Address, isAddress } from 'viem'; | ||
|
|
||
| /** | ||
| * Frontend-configured fee recipient for Smart Rebalance. | ||
| * | ||
| * Set `NEXT_PUBLIC_SMART_REBALANCE_FEE_RECIPIENT` in your env to override. | ||
| * Fallback keeps current production behavior until explicitly changed. | ||
| */ | ||
| const DEFAULT_FEE_RECIPIENT = '0xc8440DF82b5Eb7Ff1dc1DcB4d756bd35B9340B7C'; | ||
|
|
||
| const configuredRecipient = process.env.NEXT_PUBLIC_SMART_REBALANCE_FEE_RECIPIENT?.trim(); | ||
| const resolvedRecipient = configuredRecipient ?? DEFAULT_FEE_RECIPIENT; | ||
|
|
||
| if (!isAddress(resolvedRecipient)) { | ||
| throw new Error('NEXT_PUBLIC_SMART_REBALANCE_FEE_RECIPIENT must be a valid EVM address.'); | ||
| } | ||
|
|
||
| export const SMART_REBALANCE_FEE_RECIPIENT: Address = resolvedRecipient; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a collision-safe key for summary rows.
Line 58 uses
item.labelas the key. Repeated labels can collide and cause row reuse glitches.Suggested fix
As per coding guidelines: "Use the key prop for elements in iterables (prefer unique IDs over array indices)".
🤖 Prompt for AI Agents