Skip to content

chore: fix rate#482

Merged
antoncoding merged 1 commit intomasterfrom
fix/borrow-apy
Mar 29, 2026
Merged

chore: fix rate#482
antoncoding merged 1 commit intomasterfrom
fix/borrow-apy

Conversation

@antoncoding
Copy link
Copy Markdown
Owner

@antoncoding antoncoding commented Mar 29, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Added loading indicators for borrow rates while historical rate data is being retrieved, providing better visual feedback during the enrichment process
    • Enhanced market data resolution to ensure accurate rate information by properly matching market data against the complete markets dataset
    • Improved fallback displays when rate data is unavailable

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Mar 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
monarch Ready Ready Preview, Comment Mar 29, 2026 8:03am

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1a06d504-a39a-4a02-a22d-569fc2d49ff2

📥 Commits

Reviewing files that changed from the base of the PR and between 46e2113 and f44d301.

📒 Files selected for processing (1)
  • src/features/positions/components/borrowed-morpho-blue-row-detail.tsx

📝 Walkthrough

Walkthrough

Updated the borrowed-morpho-blue-row-detail component to resolve rows against all markets and added a rate-rendering helper that displays loading states while rate enrichment is in progress, replacing blank fallbacks.

Changes

Cohort / File(s) Summary
Borrow Rate Display
src/features/positions/components/borrowed-morpho-blue-row-detail.tsx
Added renderHistoricalRateValue() helper for conditional rate rendering with loading states. Implemented market resolution using useProcessedMarkets() to derive resolved rows. Updated "1 Day" and "7 Days" borrow-rate displays to use the new helper instead of static fallbacks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

ui

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and doesn't clearly describe the main change—it just says 'fix rate' without explaining what specifically was fixed or how. Use a more specific title like 'Fix borrow APY display with loading state and market resolution' or similar to convey what rate issue was addressed.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/borrow-apy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the ui User interface label Mar 29, 2026
@antoncoding antoncoding merged commit 32e0c19 into master Mar 29, 2026
4 checks passed
@antoncoding antoncoding deleted the fix/borrow-apy branch March 29, 2026 08:13
This was referenced Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui User interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant