Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughSwitches ERC4626 flash-leg callback from mint→deposit, threads ERC4626 previewDeposit/previewRedeem results through leverage/deleverage quote logic with slippage-floor application, updates related UI labels/controls, replaces token-formatting calls with a new token-aware formatter, and refactors metric/tooltip rendering in several modal and table components. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as Leverage UI
participant QuoteHook as useLeverageQuote
participant LeverageHook as leverageWithErc4626Deposit
participant FlashLoan as FlashLoanProvider
participant Vault as ERC4626 Vault
User->>UI: open modal / request quote (route=erc4626)
UI->>QuoteHook: request quote (loan input)
QuoteHook->>Vault: previewDeposit(flashLoanAssetAmount) / previewMint (user path)
Vault-->>QuoteHook: preview results (shares)
QuoteHook-->>UI: quote with slippage floors (initial & flash-leg min shares)
UI->>LeverageHook: submit leverage tx (includes min share floors)
LeverageHook->>FlashLoan: request flash loan (assetAmount)
FlashLoan->>LeverageHook: provide assets & invoke callback
LeverageHook->>Vault: erc4626Deposit(assetAmount, minShares)
Vault-->>LeverageHook: deposit result (shares minted)
LeverageHook->>FlashLoan: repay flash loan
LeverageHook-->>UI: tx result
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/modals/borrow/components/borrow-position-risk-card.tsx (1)
318-350: Optional: extract a shared asset metric row.Collateral and debt blocks now follow the same structure; a tiny helper/component could reduce duplication and future drift.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/modals/borrow/components/borrow-position-risk-card.tsx` around lines 318 - 350, Extract a reusable AssetMetricRow component to remove duplication between the collateral and debt blocks: create a new component (e.g., AssetMetricRow) that accepts props used in both instances — title, isPreview, detail, secondaryDetail, displayAmount, fullAmount, symbol, valueClassName, tokenAddress, chainId, tokenSymbol, and labelClassName — and replaces the duplicated JSX where TokenIcon and TokenMetricValue are rendered; update the collateral block to call <AssetMetricRow ...> with collateral* props (showProjectedCollateral, collateralCurrentDetail, collateralProjectedDetail, collateralDeltaLabel, collateralDisplay, market.collateralAsset.address, market.morphoBlue.chain.id, metricLabelClassName, etc.) and the debt block to call it with borrow* props (showProjectedBorrow, borrowCurrentDetail, borrowProjectedDetail, borrowDeltaLabel, borrowDisplay, market.loanAsset.address, market.morphoBlue.chain.id, metricLabelClassName, etc.), preserving class names and prop names used by TokenMetricValue and TokenIcon so behavior and styling remain unchanged.src/features/positions/components/supplied-morpho-blue-grouped-table.tsx (1)
280-282: Optional: computeearningsPreviewonce per row.
formatTokenAmountPreview(...)is called twice in the same render path. Hoisting it once nearconst earnings = ...would simplify this block.Also applies to: 303-306
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/features/positions/components/supplied-morpho-blue-grouped-table.tsx` around lines 280 - 282, Hoist the call to formatTokenAmountPreview by computing const earningsPreview = formatTokenAmountPreview(earnings, groupedPosition.loanAssetDecimals) once per row (near where const earnings is defined) and reuse earningsPreview.full and earningsPreview.short instead of calling formatTokenAmountPreview again; update the places that build exactTokenAmount and the shortened display (the duplicated calls around exactTokenAmount and the later display at lines ~303-306) to reference the single earningsPreview variable.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/utils/balance.ts`:
- Around line 60-61: The current code uses Number.parseFloat which silently
accepts partial numeric strings; replace the parseFloat logic in the
numericValue assignment inside src/utils/balance.ts so string inputs are
strictly converted with Number (e.g. const numericValue = typeof value ===
'string' ? Number(value.trim()) : value) or validated with a strict numeric
regex before parsing, then keep the existing Number.isFinite(numericValue)
fallback; update the handling around numericValue (the same variable and
conditional) so values like "1,234.56" or "12abc" produce the fallback string
instead of a truncated number.
---
Nitpick comments:
In `@src/features/positions/components/supplied-morpho-blue-grouped-table.tsx`:
- Around line 280-282: Hoist the call to formatTokenAmountPreview by computing
const earningsPreview = formatTokenAmountPreview(earnings,
groupedPosition.loanAssetDecimals) once per row (near where const earnings is
defined) and reuse earningsPreview.full and earningsPreview.short instead of
calling formatTokenAmountPreview again; update the places that build
exactTokenAmount and the shortened display (the duplicated calls around
exactTokenAmount and the later display at lines ~303-306) to reference the
single earningsPreview variable.
In `@src/modals/borrow/components/borrow-position-risk-card.tsx`:
- Around line 318-350: Extract a reusable AssetMetricRow component to remove
duplication between the collateral and debt blocks: create a new component
(e.g., AssetMetricRow) that accepts props used in both instances — title,
isPreview, detail, secondaryDetail, displayAmount, fullAmount, symbol,
valueClassName, tokenAddress, chainId, tokenSymbol, and labelClassName — and
replaces the duplicated JSX where TokenIcon and TokenMetricValue are rendered;
update the collateral block to call <AssetMetricRow ...> with collateral* props
(showProjectedCollateral, collateralCurrentDetail, collateralProjectedDetail,
collateralDeltaLabel, collateralDisplay, market.collateralAsset.address,
market.morphoBlue.chain.id, metricLabelClassName, etc.) and the debt block to
call it with borrow* props (showProjectedBorrow, borrowCurrentDetail,
borrowProjectedDetail, borrowDeltaLabel, borrowDisplay,
market.loanAsset.address, market.morphoBlue.chain.id, metricLabelClassName,
etc.), preserving class names and prop names used by TokenMetricValue and
TokenIcon so behavior and styling remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c2c006f3-64d9-437e-b01f-80099063ddff
📒 Files selected for processing (4)
src/features/positions/components/borrowed-morpho-blue-table.tsxsrc/features/positions/components/supplied-morpho-blue-grouped-table.tsxsrc/modals/borrow/components/borrow-position-risk-card.tsxsrc/utils/balance.ts
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/hooks/useLeverageQuote.ts (1)
107-126: Preview usespreviewMintbut execution useserc4626Deposit.The guideline states "previewMint→exact-share mint", but the execution path uses
erc4626Depositwith the previewed assets. Per the context inleverageWithErc4626Deposit.ts, this is intentional: depositing exact assets with a share floor "keeps the flash leg executable even if the vault's share price moved enough that an exact-share mint would require more assets than the flash loan supplied."The slippage floor at line 243 protects against unfavorable price movements. The trade-off is potentially receiving slightly fewer shares than targeted if the share price increases.
Consider adding a brief comment near
previewMintusage (around line 119-120) noting that execution intentionally uses deposit-with-floor rather than exact-share mint to handle share price movement.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/hooks/useLeverageQuote.ts` around lines 107 - 126, Add a short inline comment next to the previewMint call in useLeverageQuote.ts (the useReadContract call with functionName 'previewMint' and arg targetFlashCollateralTokenAmount) stating that although previewMint is used to estimate exact-share requirements, the actual execution path uses erc4626Deposit (see leverageWithErc4626Deposit.ts) which deposits assets with a share-floor to remain executable if the vault share price rises; mention that the slippage/floor protection is applied at execution to avoid failing the flash leg.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/hooks/useLeverageQuote.ts`:
- Around line 107-126: Add a short inline comment next to the previewMint call
in useLeverageQuote.ts (the useReadContract call with functionName 'previewMint'
and arg targetFlashCollateralTokenAmount) stating that although previewMint is
used to estimate exact-share requirements, the actual execution path uses
erc4626Deposit (see leverageWithErc4626Deposit.ts) which deposits assets with a
share-floor to remain executable if the vault share price rises; mention that
the slippage/floor protection is applied at execution to avoid failing the flash
leg.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e6e48472-342d-467f-b66c-7c2fb7adad48
📒 Files selected for processing (3)
src/hooks/deleverage/deleverageWithErc4626Redeem.tssrc/hooks/useDeleverageQuote.tssrc/hooks/useLeverageQuote.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements