fix: sorting by created at and updated at not working properly#74
Merged
antonreshetov merged 2 commits intoantonreshetov:masterfrom Mar 14, 2020
Conversation
Owner
|
Thank you for the PR. But let's stick to the rule, no side effects. Only bug - fix. Editor settings are a personal user preference. |
Contributor
Author
|
@antonreshetov Sure thing. Maybe |
antonreshetov
approved these changes
Mar 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I just found this project and loved it and wanted to contribute. I noticed that sorting by
created_atandupdated_atwas not working properly due to incorrectly named props.Screencap of the bug:
This PR also adds a workspace setting to not formatOnSave as the formatter is not working nicely together with eslint specifically for this rule:
prettier/prettier#3161
Looking forward do contribute!
Thank you for your contribution to the massCode repo.
Before submitting this PR, please make sure:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
masterbranch for v1.xfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes: