feat: reject feedback prompt (60s window) + timeout UX cleanup#1
Closed
wangyuyan-agent wants to merge 1 commit intoantx-code:mainfrom
Closed
feat: reject feedback prompt (60s window) + timeout UX cleanup#1wangyuyan-agent wants to merge 1 commit intoantx-code:mainfrom
wangyuyan-agent wants to merge 1 commit intoantx-code:mainfrom
Conversation
- After Reject, bot sends a follow-up message prompting for an optional reason. User has 60 seconds to reply; if they do, the feedback is captured in the JSON output under the existing 'feedback' field. If no reply arrives within 60s, the request exits cleanly with feedback: null. - On timeout, the inline keyboard is now removed from the original message and a localised '⏰ Request timed out' notice is sent, so users aren't left with stale Approve/Reject buttons. - New i18n strings added for all three locales (en, zh-CN, zh-TW): reject_feedback_prompt, reject_feedback_callback, timeout_notice.
Owner
|
Thanks for the PR! Both ideas are solid:
We're going to implement these ourselves with a few adjustments:
Closing in favor of our own implementation. Thanks again for the contribution and the clean code — it made the review easy. 🙏 |
antx-code
pushed a commit
that referenced
this pull request
Mar 9, 2026
Inspired by PR #1 (thanks @wangyuyan-agent). - After reject, send follow-up asking for reason; accept any text message from trusted user within configurable window (default 60s) - On timeout, remove stale inline keyboard + send timeout notice - New config: reject_feedback_timeout (seconds, 0 to skip) - New i18n strings: reject_feedback_prompt, timeout_notice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two UX improvements for the Telegram provider:
1. Reject feedback prompt (60-second window)
After clicking Reject, the bot now sends a follow-up message:
"feedback": "<reason>")"feedback": null1This fills the pre-existing
feedbackfield that was alwaysnullfor rejected requests.2. Timeout UX cleanup
Previously, when a request timed out the inline keyboard stayed on the original message with no indication that the request had expired.
Now on timeout:
editMessageReplyMarkup)⏰ Request timed out — no response received.2is unchangedLocalisation
New strings added for
en,zh-CN, andzh-TW:reject_feedback_promptreject_feedback_callbacktimeout_noticeTesting
cargo build # passes with zero warningsManual flow:
openfeedback send --title "Test" --body "body"→ click Reject → reply with reason → JSON shows"feedback": "your reason""feedback": null