Skip to content

Feature: Stats card: Show merged PRs count and percentage#3003

Merged
qwerty541 merged 7 commits intomasterfrom
show_merged_prs_stats
Aug 13, 2023
Merged

Feature: Stats card: Show merged PRs count and percentage#3003
qwerty541 merged 7 commits intomasterfrom
show_merged_prs_stats

Conversation

@qwerty541
Copy link
Collaborator

@qwerty541 qwerty541 commented Jul 28, 2023

This pull request adds ability to show count and percentage of merged PRs on stats card using &show= query option.

image

I'm not sure about merged PRs percentage icon, what do you think @rickstaa?

@qwerty541 qwerty541 requested a review from rickstaa July 28, 2023 18:59
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Aug 13, 2023 11:02pm

@github-actions github-actions bot added documentation Improvements or additions to documentation. stats-card Feature, Enhancement, Fixes related to stats the stats card. card-i18n Card text translations. labels Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (135176f) 97.62% compared to head (f1c9dba) 97.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
+ Coverage   97.62%   97.66%   +0.04%     
==========================================
  Files          24       24              
  Lines        5343     5440      +97     
  Branches      466      469       +3     
==========================================
+ Hits         5216     5313      +97     
  Misses        125      125              
  Partials        2        2              
Files Changed Coverage Δ
src/cards/stats-card.js 98.37% <100.00%> (+0.10%) ⬆️
src/common/icons.js 100.00% <100.00%> (ø)
src/fetchers/stats-fetcher.js 93.44% <100.00%> (+0.18%) ⬆️
src/translations.js 99.86% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickstaa I committed an alternate icon for "Merged PRs Percentage" stat. Let me know which of them better on your opinion.

image

Copy link
Collaborator

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the naming, I think this pull request is clean 🚀! Feel free to merge it if you want.

readme.md Outdated
You can pass a query parameter `&show=` to show any specific additional stats with comma-separated values.

> Options: `&show=reviews,discussions_started,discussions_answered`
> Options: `&show=reviews,discussions_started,discussions_answered,prs_merged,merged_prs_percentage`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for consistency, we can call it prs_merged, prs_merged_percentage. I am, however, also good with your current names if you think they are more apparent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have update the code following your suggestion. Maybe it's better, but it hard for me to judge since i'm not english native speaker.

@qwerty541 qwerty541 merged commit a258b29 into master Aug 13, 2023
@qwerty541 qwerty541 deleted the show_merged_prs_stats branch August 13, 2023 23:19
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
…a#3003)

* Feature: Stats card: Show merged PRs count and percentage

* dev

* dev

* renames
ABA2396 pushed a commit to ABA2396/github-readme-stats that referenced this pull request Dec 22, 2023
…a#3003)

* Feature: Stats card: Show merged PRs count and percentage

* dev

* dev

* renames
ABA2396 pushed a commit to ABA2396/github-readme-stats that referenced this pull request Dec 22, 2023
…a#3003)

* Feature: Stats card: Show merged PRs count and percentage

* dev

* dev

* renames
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
…a#3003)

* Feature: Stats card: Show merged PRs count and percentage

* dev

* dev

* renames
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this pull request Nov 6, 2024
…a#3003)

* Feature: Stats card: Show merged PRs count and percentage

* dev

* dev

* renames
necofuryai added a commit to necofuryai/github-readme-stats that referenced this pull request May 19, 2025
…a#3003)

* Feature: Stats card: Show merged PRs count and percentage

* dev

* dev

* renames
xhayper pushed a commit to xhayper/github-readme-stats that referenced this pull request Jul 2, 2025
…a#3003)

* Feature: Stats card: Show merged PRs count and percentage

* dev

* dev

* renames
zimya pushed a commit to zimya/github-readme-stats-cf that referenced this pull request Jan 13, 2026
…a#3003)

* Feature: Stats card: Show merged PRs count and percentage

* dev

* dev

* renames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

card-i18n Card text translations. documentation Improvements or additions to documentation. stats-card Feature, Enhancement, Fixes related to stats the stats card.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Show count and percentage of merged pull requests on stats card

2 participants

Comments