Add python generated files to be excluded from rat check #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
reviewed
Nov 23, 2022
| <configuration> | ||
| <excludes> | ||
| <exclude>src/main/resources/META-INF/services/*</exclude> | ||
| <exclude>src/main/python/AccumuloProxy.egg-info/*</exclude> |
Member
There was a problem hiding this comment.
It's fine if these are ignored, but another option might be to add the license header automatically, like the main accumulo repo does.
Member
Author
There was a problem hiding this comment.
Good idea. Maybe ill merge this in as-is, then create a follow on ticket for that change.
Kidcredible300
added a commit
to Kidcredible300/accumulo-proxy
that referenced
this pull request
Aug 18, 2025
Kidcredible300
added a commit
to Kidcredible300/accumulo-proxy
that referenced
this pull request
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This directory,
src/main/python/AccumuloProxy.egg-info/, is generated automatically when I run through the steps to set up the test client for python. It is already in the gitignore but it fails the rat check step of the build if I do not manually delete it. The changes in this PR make it so that the files within this directory are ignored by rat check which will not fail the build if it is present.